Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Added dtype to torch deterministic action #29648

Merged
merged 12 commits into from
Oct 25, 2022
Merged

[RLlib] Added dtype to torch deterministic action #29648

merged 12 commits into from
Oct 25, 2022

Conversation

kouroshHakha
Copy link
Contributor

Why are these changes needed?

Was left out from #29600 .

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kouroshHakha
created action_dist_v2 for RLModule examples
da8f916 
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
@kouroshHakha
Merge branch 'master' into action-dist-v2
d366847
@kouroshHakha
torch.pi to math.pi
f96534c 
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
@kouroshHakha
added missing docstrings and some nit renames
4bcad07 
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
@kouroshHakha
lint
486f3d2 
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
@kouroshHakha
updated test
0a50805 
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
@kouroshHakha
doscsrig
185257e 
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
@kouroshHakha
docstring
7d12b65 
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
@kouroshHakha
updated pi
8e86cb2 
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
@kouroshHakha
lint
3e2933e 
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
@kouroshHakha
Merge branch 'master' into action-dist-v2
a0fbc40
@kouroshHakha
fixed minor thing for torch dist
6f16139 
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
@kouroshHakha kouroshHakha mentioned this pull request Oct 25, 2022
Merged
7 tasks
sven1977
sven1977 approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@sven1977 sven1977 merged commit 3983002 into ray-project:master Oct 25, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@kouroshHakha @WeichenXu123
[RLlib] Fix: Added dtype to torch deterministic action. (ray-project#…
e2388c4 
…29648)

Signed-off-by: Weichen Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 sven1977 approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver

@avnishn avnishn Awaiting requested review from avnishn

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@gjoliver gjoliver

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kouroshHakha @sven1977 @gjoliver